mrutkows commented on a change in pull request #766: adding support for using
env. variables in inputs JSON
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/766#discussion_r172930215
##########
File path: wskenv/environment.go
##########
@@ -63,15 +63,21 @@ func InterpolateStringWithEnvVar(key interface{})
interface{} {
return c == '$' || c == '{' || c == '}'
}
for _, substr := range strings.FieldsFunc(keystr, f) {
- //if the substr is a $ENV_VAR
- if strings.Contains(keystr, "$"+substr) {
+ //if the substr is a $${ENV_VAR}
+ // return ${ENV_VAR}
+ if strings.Contains(keystr, "$${"+substr+"}") {
+ keystr = strings.Replace(keystr,
"$${"+substr+"}", "${"+substr+"}", -1)
+ //if the substr is a $ENV_VAR
Review comment:
hate gofmt and comment alignment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
