chetanmeh commented on issue #3482: Controller protocol should be https in controller application.conf URL: https://github.com/apache/incubator-openwhisk/issues/3482#issuecomment-377674091 > If there is real ambiguity going on here (first need to verify that the generated application.conf on the classpath is as expected?) @tysonnorris Logically yes as the value of `controller.protocol` is being set to2 different value in 2 different application.conf. Its not guaranteed that application.conf present in tests would supercede any other application.conf as the order as seen by typesafe config logic would not be deterministic. > move everything into reference.conf (not just controller parts); one reference.conf per each of invoker+controller We can safely move all properties under `whisk` path to reference.conf. However any other property cannot be moved as same property present in 2 reference.conf would end up in non deterministic resolution. > OR, stop relying on application.conf.j2 - I think this is already a suspicious practice of generating code into tests/src/test/resources/ directory That may be better. This would also simplify work being done as part of #3492 by @jonpspri. However this may make running tests within IDE bit difficult as IDE test runner may not pick those properties (to be checked). Though Intellij can be configured to use [Gradle Test Runner][1] I am not sure if we loose any features with that [1]: http://mrhaki.blogspot.in/2016/03/gradle-goodness-configure-intellij-idea.html
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
