chetanmeh commented on a change in pull request #3689: Enable extending
environment variables of Controller and Invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3689#discussion_r190466946
##########
File path: ansible/environments/local/group_vars/all
##########
@@ -2,6 +2,7 @@
# license agreements; and to You under the Apache License, Version 2.0.
whisk_version_name: local
+extraEnvSets: "{{ lookup('env', 'OPENWHISK_EXTRA_ENV_SETS')|default(false,
true) }}"
Review comment:
Makes sense. Update PR to support specific env for controller and invoker.
By default they both rely on `OPENWHISK_EXTRA_ENV`. However one can change the
setting in environment specific file.
Not sure on best practices for placing the vars in ansible ... for now I
have added them to `local/group_vars/all` such that one can use a different
setting in specific env
```
ansible/environments/custom/group_vars
controller:
extraEnv: "cosmos,splunk"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
