csantanapr commented on issue #3689: Enable extending environment variables of 
Controller and Invoker
URL: 
https://github.com/apache/incubator-openwhisk/pull/3689#issuecomment-392219418
 
 
   Hey @chetanmeh please review the commit I just pushed 
https://github.com/apache/incubator-openwhisk/pull/3689/commits/fd358716d3ba7ba20960ed9b802a142d67345569
   It's was what I was proposing we do is much simpler, it allows override from 
an environment.
   Also it does proper combine using `dict` in ansible
   
   Now you are able to edit your own environment like `environment/local` and 
add something like
   ```
   controller_extraEnv:
     CONFIG_whisk_cosmosdb_endpoint : "https://<account 
name>.documents.azure.com:443/"
     CONFIG_whisk_cosmosdb_key : "some secret"
     CONFIG_whisk_cosmosdb_db : openwhisk
   invoker_extraEnv:
     CONFIG_whisk_cosmosdb_endpoint : "https://<account 
name>.documents.azure.com:443/"
     CONFIG_whisk_cosmosdb_key : "some secret"
     CONFIG_whisk_cosmosdb_db : openwhisk
   ```
   You can do it like this ^^ or in your environment load an environment 
variable into the environment file, or override using `ansible-playbook -e`
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to