rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193252805
##########
File path:
tests/src/test/scala/whisk/core/controller/test/WebActionsApiTests.scala
##########
@@ -1747,7 +1747,7 @@ trait WebActionsApiBaseTests extends
ControllerTestCommon with BeforeAndAfterEac
}
class TestingEntitlementProvider(config: WhiskConfig, loadBalancer:
LoadBalancer)
- extends EntitlementProvider(config, loadBalancer, InstanceId(0)) {
Review comment:
if we can make all InstanceId essentially a StringInstanceId, then an
`apply(int)` instance would provide backward compatibility so you don't have to
change all the cons sites.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
