csantanapr commented on a change in pull request #3467: Remove
actionControllers tests from incubator-openwhisk repo
URL:
https://github.com/apache/incubator-openwhisk/pull/3467#discussion_r193860177
##########
File path: tests/src/test/scala/actionContainers/ActionContainer.scala
##########
@@ -104,19 +113,25 @@ object ActionContainer {
sys.props
.get("docker.host")
.orElse(sys.env.get("DOCKER_HOST"))
+ .orElse {
+ // Check if we are running on docker-machine env.
+
Option(WhiskProperties.getProperty("whisk.version.name")).filter(_.toLowerCase.contains("mac")).map
{
+ case _ => s"tcp://${WhiskProperties.getMainDockerEndpoint}"
+ }
+ }
Review comment:
I don't like this, I don't want the runtimes test to rely on WhiskProperties
to have a `whisk.properties` file present.
If user is using docker-machine the `DOCKER_HOST` env variable needs to be
set and use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
