rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193903495
##########
File path:
core/controller/src/main/scala/whisk/core/controller/Controller.scala
##########
@@ -202,7 +202,7 @@ object Controller {
// if deploying multiple instances (scale out), must pass the instance
number as the
require(args.length >= 1, "controller instance required")
- val instance = args(0).toInt
+ val instance = ControllerInstanceId(args(0).trim)
Review comment:
i think trim is not necessary since you will replace space it in the
constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
