rabbah commented on a change in pull request #3707: enable concurrent runs on
ActionContainer test utility
URL:
https://github.com/apache/incubator-openwhisk/pull/3707#discussion_r193919343
##########
File path: tests/src/test/scala/actionContainers/ActionContainer.scala
##########
@@ -65,13 +67,26 @@ trait ActionProxyContainerTestUtils extends FlatSpec with
Matchers with StreamLo
def checkStreams(out: String,
err: String,
additionalCheck: (String, String) => Unit,
- sentinelCount: Int = 1): Unit = {
+ sentinelCount: Int = 1,
+ concurrent: Boolean = false): Unit = {
withClue("expected number of stdout sentinels") {
sentinelCount shouldBe StringUtils.countMatches(out, sentinel)
}
+ //sentinels should be all together
+ if (concurrent) {
Review comment:
could you just count the number of sentinel occurrences to match the number
of activations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
