markusthoemmes commented on a change in pull request #3747: Memory based
loadbalancing
URL:
https://github.com/apache/incubator-openwhisk/pull/3747#discussion_r196387058
##########
File path:
tests/src/test/scala/whisk/core/containerpool/test/ContainerPoolTests.scala
##########
@@ -124,7 +129,7 @@ class ContainerPoolTests
it should "reuse a warm container" in within(timeout) {
val (containers, factory) = testContainers(2)
val feed = TestProbe()
- val pool = system.actorOf(ContainerPool.props(factory,
ContainerPoolConfig(2, 2), feed.ref))
+ val pool = system.actorOf(ContainerPool.props(factory,
ContainerPoolConfig(MemoryLimit.stdMemory * 4), feed.ref))
Review comment:
Please add a comment somewhere, that an action is created with stdMemory by
default, so this is preserving behavior (4 actions can be scheduled)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
