markusthoemmes commented on a change in pull request #3950: Extend system
testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208495717
##########
File path: tests/src/test/scala/common/rest/WskRestOperations.scala
##########
@@ -1202,6 +1220,16 @@ trait RunRestCmd extends Matchers with ScalaFutures
with SwaggerValidator {
response
}
+ def logRequestResponse(req: HttpRequest, res: HttpResponse) {
+ logger.debug(this, s"Request Method: ${req.method}")
+ logger.debug(this, s"Request URI: ${req.uri}")
+ logger.debug(this, s"Request Headers: ${req.headers.mkString(",")}")
+ logger.debug(this, s"Request Body: ${getReqData(req)}")
+ logger.debug(this, s"Response Status: ${res.status.intValue()}")
+ logger.debug(this, s"Response Headers: ${res.headers.mkString(",")}")
+ logger.debug(this, s"Response Body: ${getRespData(res)}")
Review comment:
Since we "strictify" responses already, could you just print the whole
request and the whole response? Scala case-class's `toString` should be
sufficient to provide all the information needed, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
