dubee commented on a change in pull request #3941: to address #3918, reuse a
container on applicationError
URL:
https://github.com/apache/incubator-openwhisk/pull/3941#discussion_r208698819
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/ContainerProxy.scala
##########
@@ -419,9 +419,10 @@ class ContainerProxy(
// Disambiguate activation errors and transform the Either into a
failed/successful Future respectively.
activationWithLogs.flatMap {
- case Right(act) if !act.response.isSuccess =>
Future.failed(ActivationUnsuccessfulError(act))
- case Left(error) => Future.failed(error)
- case Right(act) => Future.successful(act)
+ case Right(act) if !act.response.isSuccess &&
!act.response.isApplicationError =>
Review comment:
@tysonnorris, is it possible to just check for
`!act.response.isApplicationError` here instead? Not sure if
`!act.response.isSuccess` is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
