mgencur commented on a change in pull request #3950: Extend system testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208896992
##########
File path:
tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala
##########
@@ -462,6 +462,58 @@ class ActivationsApiTests extends ControllerTestCommon
with WhiskActivationsApi
}
}
+ it should "skip activations and return correct ones" in {
+ implicit val tid = transid()
+ val activations = (1 to 3).map { _ =>
+ WhiskActivation(
+ namespace,
+ aname(),
+ creds.subject,
+ ActivationId.generate(),
+ start = Instant.now,
+ end = Instant.now)
+ }.toList
+
+ try {
+ activations.foreach(storeActivation)
+ waitOnListActivationsInNamespace(namespace, 3)
+
+ Get(s"$collectionPath?skip=1") ~> Route.seal(routes(creds)) ~> check {
+ status should be(OK)
+ val activations = responseAs[List[JsObject]]
+ activations.length should be(2)
Review comment:
There are two problems with this solution:
1) the two json results are not completely equal (one of them has more
fields)
2) it looks like the activations might be returned in different order so it
might be different every time
Comparing just the size of the results is more robust
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
