jiangpengcheng opened a new pull request #3656: Adjust the behavior when update controller cluster URL: https://github.com/apache/incubator-openwhisk/pull/3656 Set the max permits for each invokerSlot instead of creating new ForcibleSemaphore. New ForcibleSemaphore will ignore acquired permits, so after these permits are released, the max permits of invokerSlot will exceed the `currentInvokerThreshold`, which is not what we want ## Description in some case, the `availablePermits` may exceed the `currentInvokerThreshold`, which may cause some invokers take more invoking requests than the number they can handle and other invokers are still idle ## Related issue and scope - [x] I opened an issue to propose and discuss this change (#3655) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [x] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [x] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
