rabbah commented on a change in pull request #4115: Don't react on Completion
message of blocking requests.
URL:
https://github.com/apache/incubator-openwhisk/pull/4115#discussion_r235121779
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerProxy.scala
##########
@@ -530,8 +530,16 @@ class ContainerProxy(
activationWithLogs
.map(_.fold(_.activation, identity))
.foreach { activation =>
- // Sending the completionMessage to the controller asynchronously.
- sendActiveAck(tid, activation, job.msg.blocking,
job.msg.rootControllerIndex, job.msg.user.namespace.uuid, true)
+ // Sending the completionMessage to the controller asynchronously. But
not before result message is sent.
Review comment:
maybe im confused by the view on github - is the active ack sent twice for
blocking invokes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
