tysonnorris commented on a change in pull request #4126: Fix netty leak in
CosmosDBArtifactStore`
URL:
https://github.com/apache/incubator-openwhisk/pull/4126#discussion_r235440482
##########
File path:
tests/src/test/scala/org/apache/openwhisk/core/database/cosmosdb/CosmosDBArtifactStoreTests.scala
##########
@@ -27,6 +29,27 @@ import
org.apache.openwhisk.core.database.test.behavior.ArtifactStoreBehavior
class CosmosDBArtifactStoreTests extends FlatSpec with
CosmosDBStoreBehaviorBase with ArtifactStoreBehavior {
override protected def maxAttachmentSizeWithoutAttachmentStore = 1.MB
+ private var initialLevel: Level = _
+
+ override protected def beforeAll(): Unit = {
+ RecordingLeakDetectorFactory.register()
Review comment:
Is there any reason not to register this leak detector via the
CosmosDBArtifactStore? So that if someone enabled the appropriate leak
detection level via system properties, the artifact store can be debugged in
the openwhisk system, not just in the test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
