steffenrost commented on a change in pull request #4403: Add detailed error and
reason information to status code
URL:
https://github.com/apache/incubator-openwhisk/pull/4403#discussion_r270342508
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/http/PoolingRestClient.scala
##########
@@ -110,9 +112,17 @@ class PoolingRestClient(
if (response.status.isSuccess) {
Unmarshal(response.entity.withoutSizeLimit).to[T].map(Right.apply)
} else {
- // This is important, as it drains the entity stream.
- // Otherwise the connection stays open and the pool dries up.
- response.discardEntityBytes().future.map(_ => Left(response.status))
+ Unmarshal(response.entity).to[JsObject].flatMap { responseEntity =>
+ val error = responseEntity.fields.get("error").getOrElse("").toString
+ val reason =
responseEntity.fields.get("reason").getOrElse("").toString
+ val statusCode = response.status
+ val statusCodeReason = statusCode.reason()
+ val customReason = s"$statusCodeReason (error: $error, reason:
$reason)"
+ val customStatusCode = StatusCodes.custom(intValue =
statusCode.intValue(), reason = customReason, defaultMessage =
statusCode.defaultMessage())
Review comment:
Yes makes sense, we changed the implementation to parse String instead of
JSON. For the discussed error case the info now looks as follow:
`Unexpected http response code: 400 Bad Request
(details:{"error":"query_parse_error","reason":"Limit is too large, must not
exceed 268435456"} ) [marker:database_queryView_error:402:33]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
