falkzoll opened a new pull request #4450: Fix test cases to also work with nodejs:10 as default nodejs runtime. URL: https://github.com/apache/incubator-openwhisk/pull/4450 Fix the automated test cases to also work with nodejs:10 as default nodejs runtime. These changes are to prepare for the upcoming nodejs:6 deprecation. ## Description When switching to nodejs:10 as the default nodejs runtime, several testcases fail. Reason for this is, that the test cases assume/expect, nodejs:6 is used to execute the actions. With the deprecation of nodejs:6 it will be necessary that the tests will work with a newer nodejs version. The testcases have now been modified to work with nodejs:6 and with nodejs:10 as the default runtime. Nodejs:8 may also work, but has not been tested. This PR does not change the default nodejs runtime. It is just to prepare for switching to nodejs:10 as the default runtime. In most cases the test now explicitly execute on nodejs:10 and also check, that they were executed in nodejs:10. Some testcases have been modified so that they run on nodejs:6 and nodejs:10. No tests have been removed, means there is no change in test coverage. The tests have been executed with nodejs:6 and with nodejs:10 as the default runtime (runtime.json). In both cases the modified tests succeed. ## Related issue and scope <!--- Please include a link to a related issue if there is one. --> - [ ] see https://github.com/apache/incubator-openwhisk/issues/4265 ## My changes affect the following components <!--- Select below all system components are affected by your change. --> <!--- Enter an `x` in all applicable boxes. --> - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [x] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: --> - [x] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
