rabbah commented on a change in pull request #4450: Fix test cases to also work with nodejs:10 as default nodejs runtime. URL: https://github.com/apache/incubator-openwhisk/pull/4450#discussion_r276256692
########## File path: tests/src/test/scala/invokerShoot/ShootInvokerTests.scala ########## @@ -172,6 +172,7 @@ class ShootInvokerTests extends TestHelpers with WskTestHelpers with JsHelpers w it should "add new parameters and annotations while copying an action" in withAssetCleaner(wskprops) { (wp, assetHelper) => + val runtime = "nodejs:10" Review comment: i'd think a more generic check is sufficient since there are unit tests that check that `:default` resolves to a specific version of a runtime. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services