upgle commented on a change in pull request #4211: Add `binding` annotation to
record an action path not resolved
URL:
https://github.com/apache/incubator-openwhisk/pull/4211#discussion_r279236972
##########
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Actions.scala
##########
@@ -595,38 +590,6 @@ trait WhiskActionsApi extends WhiskCollectionAPI with
PostActionActivation with
})
}
- /**
- * Constructs a WhiskPackage that is a merger of a package with its packing
binding (if any).
- * This resolves a reference versus an actual package and merge parameters
as needed.
- * Once the package is resolved, the operation is dispatched to the action
in the package
- * namespace.
- */
- private def mergeActionWithPackageAndDispatch(method: HttpMethod,
Review comment:
If an action is resolved before it's dispatched, there is no way to know its
original name in the activate method because it's already resolved.
So, I modified it to resolve inside the activate method after it has been
dispatched.
```scala
override def activate(user: Identity, entityName: FullyQualifiedEntityName,
env: Option[Parameters])(
implicit transid: TransactionId) = { implicit transid:
TransactionId)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
