chetanmeh commented on a change in pull request #4484: Switch to consistent
indexing policy for CosmosDB
URL:
https://github.com/apache/incubator-openwhisk/pull/4484#discussion_r285069891
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/database/cosmosdb/CosmosDBSupport.scala
##########
@@ -17,13 +17,14 @@
package org.apache.openwhisk.core.database.cosmosdb
+import akka.event.slf4j.SLF4JLogging
import com.microsoft.azure.cosmosdb._
import com.microsoft.azure.cosmosdb.rx.AsyncDocumentClient
import scala.collection.JavaConverters._
import scala.collection.immutable
-private[cosmosdb] trait CosmosDBSupport extends RxObservableImplicits with
CosmosDBUtil {
+private[cosmosdb] trait CosmosDBSupport extends RxObservableImplicits with
CosmosDBUtil with SLF4JLogging {
Review comment:
This is a one time initialization flow which so far was not passing the
`Logging` implicit. So thought its fine to use Slf4j directly. Can refactor to
pass the `Logging`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
