chetanmeh commented on issue #4481: Track Kafka client side metrics via Kamon
URL: 
https://github.com/apache/incubator-openwhisk/pull/4481#issuecomment-496557190
 
 
   > is this redundant though (when turned on) with the other kafka metric 
that's emitted by the scheduled actor?
   
   This exposes more metrics in addition to lag. So kind of complements what we 
have in scheduled actor. Going forward we may even think of removing the logic 
in scheduled actor and make use of approach like done [here][1]
   
   ```scala
   val server = ManagementFactory.getPlatformMBeanServer
   val name = new 
ObjectName(s"kafka.consumer:type=consumer-fetch-manager-metrics,client-id=$id")
   def consumerLag: Long = server.getAttribute(name, 
"records-lag-max").asInstanceOf[Double].toLong.max(0)
   ```
   
   [1]: 
https://github.com/adobe-apiplatform/openwhisk-user-events/blob/master/src/main/scala/com/adobe/api/platform/runtime/metrics/EventConsumer.scala#L126-L133

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to