chetanmeh commented on a change in pull request #4504: Remove default port on
api host.
URL:
https://github.com/apache/incubator-openwhisk/pull/4504#discussion_r290122394
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/WhiskConfig.scala
##########
@@ -54,8 +54,16 @@ class WhiskConfig(requiredProperties: Map[String, String],
val dockerEndpoint = this(WhiskConfig.dockerEndpoint)
val dockerPort = this(WhiskConfig.dockerPort)
- val wskApiHost = this(WhiskConfig.wskApiProtocol) + "://" +
this(WhiskConfig.wskApiHostname) + ":" + this(
- WhiskConfig.wskApiPort)
+ val wskApiHost = {
Review comment:
Can possibly be simplified by using `akka.http.scaladsl.model.Uri.normalize`
```suggestion
val wskApiHost =
Uri.normalize(s"${this(WhiskConfig.wskApiProtocol)}://${this(WhiskConfig.wskApiHostname)}:${this(WhiskConfig.wskApiPort)}")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
