rabbah commented on a change in pull request #4516: Openwhisk in a standalone
runnable jar
URL:
https://github.com/apache/incubator-openwhisk/pull/4516#discussion_r295764144
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/database/memory/MemoryArtifactStore.scala
##########
@@ -285,8 +296,10 @@ class MemoryArtifactStore[DocumentAbstraction <:
DocumentSerializer](dbName: Str
}
override def shutdown(): Unit = {
- artifacts.clear()
- attachmentStore.shutdown()
+ if (!ignoreShutdown) {
Review comment:
worth commenting this - i dont understand why it would be necessary at face
value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
