rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302615681
 
 

 ##########
 File path: docker-compose/Makefile
 ##########
 @@ -450,6 +450,8 @@ setup-providers:
        printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
        printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
        printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+       printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+       printf "DOCKER_IMAGE_TAG"="nightly\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   ```suggestion
        printf "DOCKER_IMAGE_TAG=$(DOCKER_IMAGE_TAG)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to