[jira] [Commented] (OPTIQ-400) RelField Trimmer needs to handle cross Joins

[Julian Hyde (JIRA)]

    [ 
https://issues.apache.org/jira/browse/OPTIQ-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14122214#comment-14122214
 ] 

Julian Hyde commented on OPTIQ-400:
-----------------------------------

I also added

{code:java}
  @Test public void testCrossJoin() {
    OptiqAssert.that()
        .with(OptiqAssert.Config.REGULAR)
        .query("select \"empid\" from \"hr\".\"emps\", \"hr\".\"depts\"")
        .convertContains("ProjectRel(empid=[$0])\n"
            + "  JoinRel(condition=[true], joinType=[inner])\n"
            + "    ProjectRel(empid=[$0])\n"
            + "      EnumerableTableAccessRel(table=[[hr, emps]])\n"
            + "    ProjectRel(DUMMY=[0])\n"
            + "      EnumerableTableAccessRel(table=[[hr, depts]])");
  }
{code}

and it works fine without your patch.

> RelField Trimmer needs to handle cross Joins
> --------------------------------------------
>
>                 Key: OPTIQ-400
>                 URL: https://issues.apache.org/jira/browse/OPTIQ-400
>             Project: Optiq
>          Issue Type: Bug
>            Reporter: Laljo John Pullokkaran
>            Assignee: Laljo John Pullokkaran
>         Attachments: optiq-400.patch
>
>
> select R1.key from R1 Join R2 would result in field trimmer asking for 
> nothing from R2. This is obviously wrong:
> It should either add a constant or get any one field so that cardinality of 
> join is maintained.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)