[ 
https://issues.apache.org/jira/browse/ORC-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642899#comment-14642899
 ] 

ASF GitHub Bot commented on ORC-9:
----------------------------------

Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/5#discussion_r35551499
  
    --- Diff: c++/src/Reader.cc ---
    @@ -854,6 +854,8 @@ namespace orc {
     
       class ReaderImpl : public Reader {
       private:
    +    const int64_t epochOffset;
    +
    --- End diff --
    
    The ColumnReader uses StripeStreamsImpl::getEpochOffset() and the 
implementation of that method uses ReaderImpl::epochOffset. The initializer for 
ReaderImpl::epochOffset uses the static method getEpochOffset, but it should 
only be called once per a reader.


> Create a ColumnVectorBatch for Timestamps
> -----------------------------------------
>
>                 Key: ORC-9
>                 URL: https://issues.apache.org/jira/browse/ORC-9
>             Project: Orc
>          Issue Type: Bug
>          Components: C++, encoding
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>
> Create a TimestampVectorBatch that uses time_t and the number of nanoseconds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to