[
https://issues.apache.org/jira/browse/ORC-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260081#comment-15260081
]
ASF GitHub Bot commented on ORC-1:
----------------------------------
Github user nahguam commented on the pull request:
https://github.com/apache/orc/pull/23#issuecomment-215073080
Excellent, Thanks!
I've just been going over all the types and have a few more:
1. `VectorizedRowBatch.toUTF8` appears to be unused
2. `OrcMap` & `OrcList` - please could the constructors be public?
3. `OrcList` - please could we have another constructor so we can pass in
the initialCapacity as per `ArrayList`?
4. `OrcUnion` - please could the class itself and the `set` method be
public?
I'm just looking at the Formats/RecordReader/RecordWriter now.
> Import code from Hive
> ---------------------
>
> Key: ORC-1
> URL: https://issues.apache.org/jira/browse/ORC-1
> Project: Orc
> Issue Type: Task
> Components: C++, encoding
> Reporter: Owen O'Malley
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
