[
https://issues.apache.org/jira/browse/ORC-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988237#comment-15988237
]
ASF GitHub Bot commented on ORC-176:
------------------------------------
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/113#discussion_r113854583
--- Diff: c++/include/orc/Statistics.hh ---
@@ -37,12 +37,76 @@ namespace orc {
* of rows because of NULL values and repeated values.
* @return the number of values
*/
- virtual uint64_t getNumberOfValues() const = 0;
+ virtual uint64_t getNumberOfValues() const {
+ return valueCount;
+ }
+
+ /**
+ * Set the number of values in this column
+ * @param newValueCount new number of values to be set
+ */
+ virtual void setNumberOfValues(uint64_t newValueCount) {
--- End diff --
If we put this into Impl classes, then there are many duplicate code which
is not elegant. So we decided to lift them up to the base classes so that
duplicate codes are reduced significantly while we were implementing the
writer. What do you think?
> Refactor common classes for writer and reader
> ---------------------------------------------
>
> Key: ORC-176
> URL: https://issues.apache.org/jira/browse/ORC-176
> Project: ORC
> Issue Type: Sub-task
> Components: C++
> Reporter: Gang Wu
> Assignee: Gang Wu
>
> Extract common classes and functions for writer and reader to share.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
