[ 
https://issues.apache.org/jira/browse/ORC-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039659#comment-16039659
 ] 

ASF GitHub Bot commented on ORC-178:
------------------------------------

Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/128#discussion_r119640657
  
    --- Diff: c++/include/orc/OrcFile.hh ---
    @@ -119,6 +120,17 @@ namespace orc {
        * @param path the name of the file in the local file system
        */
       ORC_UNIQUE_PTR<OutputStream> writeLocalFile(const std::string& path);
    +
    +  /**
    +   * Create a writer to write the ORC file.
    +   * @param type the type of data to be written
    +   * @param stream the stream to write to
    +   * @param options the options for writing the file
    +   */
    +  ORC_UNIQUE_PTR<Writer> createWriter(
    +                                      const Type& type,
    +                                      OutputStream * stream,
    --- End diff --
    
    remove space `OutputStream*`


> Implement Basic C++ Writer and Writer Option
> --------------------------------------------
>
>                 Key: ORC-178
>                 URL: https://issues.apache.org/jira/browse/ORC-178
>             Project: ORC
>          Issue Type: Sub-task
>          Components: C++
>            Reporter: Gang Wu
>            Assignee: Xiening Dai
>
> 1. write orc file header, file footer, postscript, etc.
> 2. write columns of all types 
> 3. write column statistics
> 4. write index stream in writer and reader seeks to row based on index 
> information 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to