[
https://issues.apache.org/jira/browse/ORC-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135509#comment-16135509
]
ASF GitHub Bot commented on ORC-233:
------------------------------------
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/orc/pull/160#discussion_r134293310
--- Diff: java/mapreduce/src/java/org/apache/orc/mapred/OrcInputFormat.java
---
@@ -58,7 +58,7 @@
*/
public static boolean[] parseInclude(TypeDescription schema,
String columnsStr) {
- if (columnsStr == null ||
+ if (StringUtils.isBlank(columnsStr) ||
--- End diff --
BTW, is this enough for ORC column selection to return all null fields?
It looks to me that it returns all value fields. I mean without column
selection.
> Allow `orc.include.columns` to be empty
> ---------------------------------------
>
> Key: ORC-233
> URL: https://issues.apache.org/jira/browse/ORC-233
> Project: ORC
> Issue Type: Bug
> Components: Java
> Affects Versions: 1.4.0
> Reporter: Dongjoon Hyun
>
> Apache ORC should support returning all NULLs by the following.
> {code}
> conf.set(OrcConf.INCLUDE_COLUMNS.getAttribute, "")
> {code}
> Currently, it raises the following exceptions.
> {code}
> For input string: ""
> java.lang.NumberFormatException: For input string: ""
> at
> java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
> at java.lang.Integer.parseInt(Integer.java:592)
> at java.lang.Integer.parseInt(Integer.java:615)
> at
> org.apache.orc.mapred.OrcInputFormat.parseInclude(OrcInputFormat.java:69)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
