[
https://issues.apache.org/jira/browse/ORC-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135653#comment-16135653
]
ASF GitHub Bot commented on ORC-224:
------------------------------------
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/149#discussion_r134311129
--- Diff: c++/test/TestWriter.cc ---
@@ -209,5 +209,612 @@ namespace orc {
}
EXPECT_FALSE(rowReader->next(*batch));
}
-}
+ TEST(Writer, writeStringAndBinaryColumn) {
--- End diff --
These tests can definitely be improved by using a templated test class
> Implement column writers of primitive types
> -------------------------------------------
>
> Key: ORC-224
> URL: https://issues.apache.org/jira/browse/ORC-224
> Project: ORC
> Issue Type: Sub-task
> Components: C++
> Reporter: Gang Wu
> Assignee: Gang Wu
>
> As ORC-178 has implemented basic column writers for integers. This JIRA is
> targeted at implementing ColumnWriters of remaining primitive types including
> float, double, string, binary, etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
