[
https://issues.apache.org/jira/browse/ORC-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217800#comment-16217800
]
ASF GitHub Bot commented on ORC-258:
------------------------------------
GitHub user wgtmac opened a pull request:
https://github.com/apache/orc/pull/183
ORC-258: [C++] Incorrect Decimal constructor
1. Fixed constructor Decimal::Decimal(const std::string& str).
2. Added test cases to verify it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wgtmac/orc ORC-258
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/183.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #183
----
commit 46f9011c0fa96765ecc0e7ad343ea3bd6b22aa72
Author: Gang Wu <[email protected]>
Date: 2017-10-24T22:15:12Z
ORC-258: [C++] Incorrect Decimal constructor
1. Fixed constructor Decimal::Decimal(const std::string& str).
2. Added test cases to verify it.
----
> [C++] Incorrect Decimal constructor
> -----------------------------------
>
> Key: ORC-258
> URL: https://issues.apache.org/jira/browse/ORC-258
> Project: ORC
> Issue Type: Bug
> Components: C++
> Affects Versions: 1.0.0, 1.1.0, 1.2.0, 1.3.0, 1.4.0, 1.4.1
> Reporter: Gang Wu
> Assignee: Gang Wu
>
> In the implementation of Decimal::Decimal(const std::string& str), it counts
> decimal point into the scale which is wrong.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
