[
https://issues.apache.org/jira/browse/ORC-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241169#comment-16241169
]
Gopal V commented on ORC-187:
-----------------------------
[~rajesh.balamohan]: After this fix, looks like the bottleneck is now in the
ORC-186 readLongLE() now.
> BitFieldReader has an unnecessary loop
> --------------------------------------
>
> Key: ORC-187
> URL: https://issues.apache.org/jira/browse/ORC-187
> Project: ORC
> Issue Type: Bug
> Components: Java, Reader
> Affects Versions: 1.4.0
> Reporter: Gopal V
> Assignee: Rajesh Balamohan
> Attachments: perf-top-bitReader-asm.png, perf-top-bitReader.png,
> perf_asm.png, perf_latest_patch.png, perf_with_fix.png
>
>
> {code}
> /** The number of bits in one item. Non-test code always uses 1. */
> private final int bitSize;
> {code}
> The bitField reader was originally supposed to be extensible as an Integer
> reader with packing - but HIVE-7219 introduced parallel unpack routines which
> were better.
> This makes BitFieldReader::next() the core hotspot for integer sequences.
> !perf-top-bitReader.png!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
