[ 
https://issues.apache.org/jira/browse/ORC-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441447#comment-16441447
 ] 

Jesus Camacho Rodriguez commented on ORC-340:
---------------------------------------------

[~owen.omalley], you are right, I missed the creation of the 
{{TimestampTreeReader}} in the constructor of 
{{StringGroupFromTimestampTreeReader}}, which is the class responsible for the 
time zone shifting. Hence, there is no issue for timestamp.

However, I think {{date.toString}} may still cause an issue for {{date}} type?

> ConvertTreeReaderFactory does not take into account timezone information
> ------------------------------------------------------------------------
>
>                 Key: ORC-340
>                 URL: https://issues.apache.org/jira/browse/ORC-340
>             Project: ORC
>          Issue Type: Bug
>          Components: evolution
>            Reporter: Jesus Camacho Rodriguez
>            Priority: Critical
>
> When converting timestamp/date to string group, {{toString}} is called on 
> {{java.sql.Date}} and {{java.sql.Timestamp}}, which pick up the default time 
> zone to represent the date/time as a String. This can lead to the wrong 
> String representation. See 
> {{ConvertTreeReaderFactory.StringGroupFromTimestampTreeReader}} or 
> {{ConvertTreeReaderFactory.StringGroupFromDateTreeReader}}.
> {{StringGroupFromTimestampTreeReader}} should apply shifting, similar to 
> {{TreeReaderFactory.TimestampTreeReader}}.
> {{StringGroupFromDateTreeReader}} should use a date formatter in UTC.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to