[ https://issues.apache.org/jira/browse/ORC-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543783#comment-16543783 ]
ASF GitHub Bot commented on ORC-385: ------------------------------------ GitHub user omalley opened a pull request: https://github.com/apache/orc/pull/291 ORC-385. Change RecordReader to extend Closeable. You can merge this pull request into a Git repository by running: $ git pull https://github.com/omalley/orc orc-385 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/orc/pull/291.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #291 ---- commit 903a6d6049f918566938f9621fcfadb5f146a2ac Author: Owen O'Malley <omalley@...> Date: 2018-07-13T21:55:45Z ORC-385. Change RecordReader to extend Closeable. Signed-off-by: Owen O'Malley <omal...@apache.org> ---- > Change RecordReader from AutoCloseable to Closeable > --------------------------------------------------- > > Key: ORC-385 > URL: https://issues.apache.org/jira/browse/ORC-385 > Project: ORC > Issue Type: Improvement > Reporter: Owen O'Malley > Assignee: Owen O'Malley > Priority: Major > > We currently only have RecordReader implement AutoCloseable instead of > Closeable. It would be nice to be symmetric with Writer which implements > Closeable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)