[ 
https://issues.apache.org/jira/browse/ORC-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680413#comment-16680413
 ] 

ASF GitHub Bot commented on ORC-420:
------------------------------------

wgtmac commented on a change in pull request #326: ORC-420: [C++] Implement 
string dictionary encoding for C++ writer
URL: https://github.com/apache/orc/pull/326#discussion_r232065012
 
 

 ##########
 File path: c++/include/orc/Writer.hh
 ##########
 @@ -185,6 +185,12 @@ namespace orc {
      * @return if not set, the default is false
      */
     bool getEnableIndex() const;
+
+    /**
+     * Get whether or not to enable dictionary encoding
+     * @return if not set, the default is false
+     */
+    bool getEnableDictionary() const;
 
 Review comment:
   Yup, we can do it in a separate change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [C++] Implement string dictionary encoding for C++ writer
> ---------------------------------------------------------
>
>                 Key: ORC-420
>                 URL: https://issues.apache.org/jira/browse/ORC-420
>             Project: ORC
>          Issue Type: New Feature
>          Components: C++
>            Reporter: Gang Wu
>            Assignee: Gang Wu
>            Priority: Major
>
> The scope of this Jira is to add string dictionary encoding support to C++ 
> writer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to