[
https://issues.apache.org/jira/browse/ORC-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087374#comment-17087374
]
Gopal Vijayaraghavan commented on ORC-620:
------------------------------------------
This change limits the usefulness of this interface, when it comes to applying
precompiled vector filter expressions on the other end of this interface.
The VRB retains the original offsets in the vrb and intentionally allows
scratch columns (for example a decimal conversion).
> Modify the row filter API to use BiFunction
> -------------------------------------------
>
> Key: ORC-620
> URL: https://issues.apache.org/jira/browse/ORC-620
> Project: ORC
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Major
>
> The current API for row filtering has a couple of issues:
> * The filter function is passed a VectorizedRowBatch instead of a
> MutableFilterContext.
> * The filter needs to know the precise location for the fields it needs out
> of the schema.
> I'd like to propose changing it from:
> {code:java}Consumer<VectorizedRowBatch>{code}
> to
> {code:java}BiFunction<ColumnVector[], MutableFilterContext, Boolean>{code}
> That has the advantage that the data that the function should read is
> explicitly passed to it and we remove the dependence on VectorizedRowBatch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
