[ 
https://issues.apache.org/jira/browse/ORC-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Panagiotis Garefalakis updated ORC-696:
---------------------------------------
    Description: 
SARGs mapping can fail expecting a sanitized quoted colName (parseName utility 
function): 
https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/ParserUtils.java#L255

This PR makes sure fieldNames are consistent as part of convertTypeFromProtobuf 
method.

  was:
Parsing TypeDescription from a String currently sanitizes quoted names using 
the parseName utility function: 
https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/ParserUtils.java#L164

However, this step can be skipped if the schema is created directly using: 
*TypeDescription.createStruct().addField() *


As a result, find Sargs mapping can fail expecting a sanitized internal 
colName: 
https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/ParserUtils.java#L255

This PR makes fieldNames consistent as part of convertTypeFromProtobuf method.


> Consistent TypeDescription handling for quoted field names
> ----------------------------------------------------------
>
>                 Key: ORC-696
>                 URL: https://issues.apache.org/jira/browse/ORC-696
>             Project: ORC
>          Issue Type: Improvement
>    Affects Versions: 1.7.0
>            Reporter: Panagiotis Garefalakis
>            Assignee: Panagiotis Garefalakis
>            Priority: Major
>
> SARGs mapping can fail expecting a sanitized quoted colName (parseName 
> utility function): 
> https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/ParserUtils.java#L255
> This PR makes sure fieldNames are consistent as part of 
> convertTypeFromProtobuf method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to