mwlon commented on code in PR #1141:
URL: https://github.com/apache/orc/pull/1141#discussion_r882686122
##########
java/bench/core/src/java/org/apache/orc/bench/core/Driver.java:
##########
@@ -32,8 +34,14 @@ public class Driver {
private static Map<String, OrcBenchmark> getBenchmarks() {
Map<String, OrcBenchmark> result = new TreeMap<>();
- for(OrcBenchmark bench: loader) {
- result.put(bench.getName(), bench);
+ Iterator<OrcBenchmark> iterator = loader.iterator();
Review Comment:
We need to try/catch each `.next()` call. I'm not aware of any way to do
that with an `Iterable` other than to create an `Iterator` from it, but let me
know if there is a way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
