liujiawinds commented on PR #1156: URL: https://github.com/apache/orc/pull/1156#issuecomment-1152857414
@dongjoon-hyun > 1. Do you have some documentation or reference in Apache Flink community? Yes, first we must create a stream based `PhysicalFsWriter` before `WriterImpl` initial. [WriterImpl](https://github.com/apache/orc/blob/7facf81846a5e4395f2dbab335faef93f04c6aee/java/core/src/java/org/apache/orc/impl/WriterImpl.java#L223) Then, You can look into flink orc writer from [OrcBulkWriterFactory](https://github.com/apache/flink/blob/99c2a415e9eeefafacf70762b6f54070f7911ceb/flink-formats/flink-orc/src/main/java/org/apache/flink/orc/writer/OrcBulkWriterFactory.java#L99). Given the above, now I want to passing encryption settings to `PhysicalFsWriter` before `WriterImpl` initail, but the encryption setup at `WriterImpl ` is so tightly coupled that the encryption variant cannot be obtained externally. > 2. Is this Apache ORC design issue? Yes, I think it is. > 3. Is this request aligned with other encryption handling in Apache Flink community (like Apache Parquet Modular Encryption handling)? Parquet has a similar class named `FileEncryptionProperties`. [ParquetWriter](https://github.com/apache/parquet-mr/blob/59e9f78b8b3a30073db202eb6432071ff71df0ec/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java#L283) >In general, branch-1.8 is already in feature freeze mode. I don't think this is required at v1.8.0 (currently). It's ok to release in later versions. I will extract this part of code in flink. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
