coderex2522 commented on code in PR #1158:
URL: https://github.com/apache/orc/pull/1158#discussion_r896878729
##########
c++/include/orc/Reader.hh:
##########
@@ -39,6 +39,29 @@ namespace orc {
struct ReaderOptionsPrivate;
struct RowReaderOptionsPrivate;
+ struct ReaderMetrics {
+ volatile uint64_t ReaderCount;
+ volatile uint64_t ReaderInclusiveLatencyUs;
+ volatile uint64_t DecompCount;
+ volatile uint64_t DecompLatencyUs;
+ volatile uint64_t DecodingCount;
+ volatile uint64_t DecodingLatencyUs;
+ volatile uint64_t ByteDecodingCount;
+ volatile uint64_t ByteDecodingLatencyUs;
+
+ ReaderMetrics() {
+ ReaderCount = 0;
Review Comment:
has removed the explicit constructor.
##########
c++/include/orc/Reader.hh:
##########
@@ -455,6 +478,12 @@ namespace orc {
*/
virtual bool hasCorrectStatistics() const = 0;
+ /**
+ * Get metrics of the reader
+ * @return the accumulated reader metrics to current state.
+ */
+ virtual ReaderMetrics getReaderMetrics() const = 0;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
