cxzl25 commented on code in PR #1161:
URL: https://github.com/apache/orc/pull/1161#discussion_r915455594
##########
java/mapreduce/src/java/org/apache/orc/mapred/OrcOutputFormat.java:
##########
@@ -75,6 +75,8 @@ public RecordWriter<NullWritable, V>
getRecordWriter(FileSystem fileSystem,
Path path = getTaskOutputPath(conf, name);
Writer writer = OrcFile.createWriter(path,
buildOptions(conf).fileSystem(fileSystem));
- return new OrcMapredRecordWriter<>(writer);
+ return new OrcMapredRecordWriter<>(writer,
+ OrcConf.ROW_BATCH_SIZE.getInt(conf),
Review Comment:
https://github.com/apache/orc/pull/1108#discussion_r869544673
Should we split into two configurations? In scenarios with read and write
orc, the same configuration should not be mixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
