XinyuZeng commented on PR #1158: URL: https://github.com/apache/orc/pull/1158#issuecomment-1202090174
> > @dongjoon-hyun I created jira-issue 1232 for this problem. Also, even the metrics is disabled by setting nullptr, there is still some cost of initing the AutoStopWatch object and destructing it. The following perf flamegraph shows the cost. Although the extra time may be trivial, it may be better to be disabled at compile time. > > I am confused about why does the chrono time function call still appear in the flamegraph after disabling the metrics. The SCOPED_STOPWATCH and SCOPED_MINUS_STOPWATCH macros still create the AutoStopwatch object which has chrono members, even after we pass in null METRICS_PTR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
