guiyanakuang commented on code in PR #1267:
URL: https://github.com/apache/orc/pull/1267#discussion_r1065603218


##########
java/core/src/java/org/apache/orc/OrcFile.java:
##########
@@ -905,6 +907,10 @@ public int getRowIndexStride() {
       return rowIndexStrideValue;
     }
 
+    public boolean isBuildIndex() {

Review Comment:
   > @deshanxiao It seems that we cannot revert this because this is a `public` 
API.
   
   Agree, it looks like we can only set `orc.row.index.stride` to 0 when 
`orc.create.index=false`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to