deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443591218

   > The advantage of setting it to runtime is to avoid transitive 
dependencies, as projects that depend on Orc have their own logging 
implementation. We only set it in the parent pom.xml to avoid setting it in 
each submodule, and this way the dependencies won't be as tightly coupled.
   
   1. I found that there are two slf4j-simple dependencies in the pom file, one 
in dependency and one in dependencymanagement. I remove the 
dependencymanagement one.
   2. If we add dependencies in parent pom. All modules (tools bench example) 
that depend on the pom.xml file will automatically inherit this dependency


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to