dongjoon-hyun commented on code in PR #1817:
URL: https://github.com/apache/orc/pull/1817#discussion_r1503576149
##########
java/tools/src/java/org/apache/orc/tools/RowCount.java:
##########
@@ -66,7 +66,9 @@ public static void main(Configuration conf, String[] args)
throws Exception {
}
}
}
- System.exit(bad == 0 ? 0 : 1);
+ if (bad > 0) {
+ System.exit(1);
+ }
Review Comment:
Ya, I understand the reason of this code, @cxzl25 .
Since it's worthy to have an independent JIRA ID, I suggested you to proceed
it as a new JIRA ID and PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]