wgtmac commented on code in PR #1944:
URL: https://github.com/apache/orc/pull/1944#discussion_r1621572195
##########
c++/include/orc/Exceptions.hh:
##########
@@ -67,6 +67,28 @@ namespace orc {
SchemaEvolutionError(const SchemaEvolutionError&);
SchemaEvolutionError& operator=(const SchemaEvolutionError&) = delete;
};
+
+ class CompressionError : public std::runtime_error {
+ public:
+ explicit CompressionError(const std::string& whatArg);
+ explicit CompressionError(const char* whatArg);
+ ~CompressionError() noexcept override;
+ CompressionError(const CompressionError&);
+
+ private:
+ CompressionError& operator=(const CompressionError&);
+ };
+
+ class DecompressionError : public std::runtime_error {
Review Comment:
What about just using `CompressionError` for both compression and
decompression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
