al13n321 commented on PR #1947:
URL: https://github.com/apache/orc/pull/1947#issuecomment-2146354351
Added a minimal test. It fails without the fix as expected:
```
/home/ec2-user/ClickHouse/contrib/orc/c++/test/TestWriter.cc:458: Failure
Expected equality of these values:
int_stats->getMinimum()
Which is: 0
-128
/home/ec2-user/ClickHouse/contrib/orc/c++/test/TestWriter.cc:459: Failure
Expected equality of these values:
int_stats->getMaximum()
Which is: 255
127
/home/ec2-user/ClickHouse/contrib/orc/c++/test/TestWriter.cc:461: Failure
Expected equality of these values:
int_stats->getSum()
Which is: 8355585
sum
Which is: -32767
```
Would be good to properly test statistics, with all data types, row index
statistics, random values, random stripe and row index sizes, etc, but that's
outside the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
