[ 
https://issues.apache.org/jira/browse/ORC-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gang Wu resolved ORC-1833.
--------------------------
    Fix Version/s: 2.2.0
       Resolution: Fixed

Issue resolved by pull request 2108
[https://github.com/apache/orc/pull/2108]

> [C++] Fix CMake script to be used inside another project
> --------------------------------------------------------
>
>                 Key: ORC-1833
>                 URL: https://issues.apache.org/jira/browse/ORC-1833
>             Project: ORC
>          Issue Type: Bug
>          Components: C++
>    Affects Versions: 2.1.0
>            Reporter: Gang Wu
>            Assignee: Gang Wu
>            Priority: Major
>             Fix For: 2.1.1, 2.2.0
>
>
> The change to add support for exporting CMake config and target has 
> introduced some minor issues when the ORC C++ library is used inside a larger 
> CMake project. Mainly there are three issues:
>  # We should prepend (not append) our CMake modules so we always use our own 
> modules when there are naming conflict.
>  # Do not use CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR because they are tied to 
> the root project and it is no longer ORC project when we are inside another 
> project.
>  # Add orc_ prefix to our CMake functions to avoid potential conflict.
>  
> See: https://github.com/apache/arrow/pull/45226



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to