dongjoon-hyun commented on code in PR #2121:
URL: https://github.com/apache/orc/pull/2121#discussion_r1925876317


##########
CMakeLists.txt:
##########
@@ -87,7 +87,7 @@ option(ORC_PACKAGE_KIND
 
 option(ORC_ENABLE_CLANG_TOOLS
     "Enable Clang tools"
-    ON)
+    OFF)

Review Comment:
   Hi, @wgtmac .
   
   May I ask why we need to disable this for all build?
   I guess `ORC_PACKAGE_KIND` has the information of `conan`.
   
   Can we narrow down our change into the specific `conan` build?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to